cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Heshyo <...@git.apache.org>
Subject [GitHub] cordova-plugin-dialogs pull request: set cancelable to false by de...
Date Fri, 30 Oct 2015 09:03:39 GMT
Github user Heshyo commented on the pull request:

    https://github.com/apache/cordova-plugin-dialogs/pull/56#issuecomment-152465106
  
    ++
    It's easy to tap outside of the box unintentionally. Also you may wonder what happens
if you tap outside instead of clicking OK/Cancel (did I just OKed or Cancelled it?).
    I'm actually already using a modified version of this plugin just to change that ```setCancelable```
part.
    
    @RomainFallet maybe you could simply update the calls to ```alert```, ```confirm```, ...
and add another argument ```isCancelable``` that would default to ```false``` as to not change
the current behavior on Android. Maybe people don't want to merge the PR as it's not backward
compatible?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message