cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <...@git.apache.org>
Subject [GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...
Date Sat, 24 Oct 2015 00:32:16 GMT
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/71#discussion_r42926950
  
    --- Diff: src/ios/CDVFileTransfer.m ---
    @@ -552,6 +552,8 @@ - (void)connectionDidFinishLoading:(NSURLConnection*)connection
     
         if (self.direction == CDV_TRANSFER_UPLOAD) {
             uploadResponse = [[NSString alloc] initWithData:self.responseData encoding:NSUTF8StringEncoding];
    +        if (uploadResponse == nil)
    +            uploadResponse = [[NSString alloc] initWithData: self.responseData encoding:NSISOLatin1StringEncoding];
    --- End diff --
    
    It does not look like there is a straightforward way to support this in Android, Windows.
Perhaps we should make iOS itself consistent - in terms of handling both `upload` & `download`
for this encoding. Document the limited support only in iOS, and file a `Feature Request`
JIRA to add support in Windows, Android. Also, we need to add a test case. @codable  Would
you be able to help with some of this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message