cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dpolivy <>
Subject [GitHub] cordova-plugin-camera pull request: CB-9193: Add 'showLibraryButto...
Date Fri, 23 Oct 2015 09:25:14 GMT
Github user dpolivy commented on the pull request:
    @purplecabbage On Android, the strings were previously [hardcoded](
into the plugin. My commit actually [moved them out into plugin.xml](
so they could actually be localized. The other strings (e.g. the intent names) are actually
provided by the OS based on the available activities. For WP, it is all built in to the OS,
and for iOS the one new string (Library) is added in a localizable manner consistent with
other strings in plugins.
    I don't necessarily disagree with your approach to splitting this into multiple plugins,
however I really do believe there is a useful scenario where the camera UI launches first,
but the user has a quick escape into the library. That wouldn't be supported by splitting
into 3 plugins. Instead if you really want more of a consistent experience you just have to
write to the native camera APIs directly on each platform and built a custom "Cordova" standard
UI on top of them. Having a modal source chooser step just adds complexity to the user experience
in most cases. Far better from a UX perspective to default to the 90% case (as determined
by the developer for their app) but allow easy toggling between the various options.
    In any case, it seems that there's no future hope for this PR in its current form. I still
do advocate that the problem I'm trying to solve is a valuable and important addition to the
Cordova plugins, but I'm certainly open to the form it takes as long as it meets the user
experience bar we're trying to achieve.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message