cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <>
Subject [GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...
Date Thu, 22 Oct 2015 18:40:06 GMT
Github user nikhilkh commented on a diff in the pull request:
    --- Diff: src/ios/CDVFileTransfer.m ---
    @@ -552,6 +552,8 @@ - (void)connectionDidFinishLoading:(NSURLConnection*)connection
         if (self.direction == CDV_TRANSFER_UPLOAD) {
             uploadResponse = [[NSString alloc] initWithData:self.responseData encoding:NSUTF8StringEncoding];
    +        if (uploadResponse == nil)
    +            uploadResponse = [[NSString alloc] initWithData: self.responseData encoding:NSISOLatin1StringEncoding];
    --- End diff --
    Ok - great - so the scenario is for some user to set the `charset` using Accept-charset
and then work with a server that responds with this encoding. As always, it makes sense to
validate if there are simple ways to make this cross-platform, update the docs & corresponding

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message