cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <...@git.apache.org>
Subject [GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...
Date Thu, 22 Oct 2015 17:25:19 GMT
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/71#discussion_r42778180
  
    --- Diff: src/ios/CDVFileTransfer.m ---
    @@ -552,6 +552,8 @@ - (void)connectionDidFinishLoading:(NSURLConnection*)connection
     
         if (self.direction == CDV_TRANSFER_UPLOAD) {
             uploadResponse = [[NSString alloc] initWithData:self.responseData encoding:NSUTF8StringEncoding];
    +        if (uploadResponse == nil)
    +            uploadResponse = [[NSString alloc] initWithData: self.responseData encoding:NSISOLatin1StringEncoding];
    --- End diff --
    
    Is the code below able to marshal the string with Latin1 encoding to JS or do we really
need to convert to UTF8 here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message