cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manugb <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request: Return rawId
Date Mon, 19 Oct 2015 14:27:55 GMT
Github user manugb commented on the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/68#issuecomment-149230516
  
    Hi @purplecabbage 
    Im sorry but I dont have time right now to write a test suite. Anyway here is the description
    
    It was happening to me that when I was updating a contact, the contact was getting updated
successfully BUT I got the error callback executed. 
    This seemed wierd to me so I dig in the [modifyContact](https://github.com/apache/cordova-plugin-contacts/blob/master/src/android/ContactAccessorSdk5.java#L1015)
method and find out that was returning the contactID but the [getContactByID](https://github.com/apache/cordova-plugin-contacts/blob/master/src/android/ContactAccessorSdk5.java#L302)
methods used [here](https://github.com/apache/cordova-plugin-contacts/blob/master/src/android/ContactManager.java#L106)
is expecting the RAW contactId, therefore I make the change and then I could successfully
update the contact and get the success callback executed
    
    The test should be something like:
    * get an existing contact
    * modify it and save it
    * check that the error callback was called
    * check that the contact was modified correctly despite error callack being called
    
    update modifyContact to return RawID
    * same as before but check success cb is executed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message