cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From charlesverge <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: CB-9446 Fix real path returnin...
Date Mon, 19 Oct 2015 13:58:06 GMT
Github user charlesverge commented on the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/112#issuecomment-149220643
  
    @riknoll The code in #93 is missing a null pointer check
    But the differences for the code which retrieves the url is
    #112 
    +                Cursor cursor = cordova.getActivity().managedQuery(Uri.parse(uriString),
proj, null, null, null);
    +                int column_index = cursor.getColumnIndexOrThrow(_DATA);
    +                cursor.moveToFirst();
    +                realPath = cursor.getString(column_index);
    
    #93
    +			cursor = context.getContentResolver().query(uri, projection, selection, selectionArgs,
    +					null);
    +			if (cursor != null && cursor.moveToFirst()) {
    +				final int column_index = cursor.getColumnIndexOrThrow(column);
    +				return cursor.getString(column_index);
    +			}
    
    I don't have time scheduled atm to do device testing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message