cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-plugin-file-transfer pull request: Fix/wp8 browser cookies
Date Mon, 19 Oct 2015 12:01:17 GMT
Github user daserge commented on the pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/90#issuecomment-149195485
  
    @mlaponder, @lvanengelen, thanks for your contribution!
    Is there a specific reason why you did not put the new flag to the end of the list?
    This way it would not be needed to change other platforms interface besides `wp8`.
    
    Is there an opportunity to add a test case for this?
    Do I get it right that the feature is an extension of [CB-8761 WP8: FileTransfer does
not inherit cookies from WebBrowser](https://issues.apache.org/jira/browse/CB-8761) for cross-origin
case, so that the test will require a host separate from [cordova-labs/file-transfer](https://github.com/apache/cordova-labs/tree/cordova-filetransfer)
-> [cordova-vm.apache.org](https://github.com/apache/cordova-plugin-file-transfer/blob/c79ee367a108384cbe10b8bc8038911612a67bef/tests/tests.js#L42)
test server?
    
    I propose you to refactor this in terms of not changing unrelated platforms (move `useBrowserHttp`
to the end) and send a proposal to dev@cordova.apache.org (and optionally to https://github.com/cordova/cordova-discuss/issues/)
so that the community can discuss whether to merge it in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message