cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <>
Subject [GitHub] cordova-android pull request: Cordova-Android 5.0/Marshmallow Upda...
Date Mon, 19 Oct 2015 01:26:07 GMT
Github user nikhilkh commented on a diff in the pull request:
    --- Diff: framework/src/org/apache/cordova/ ---
    @@ -359,4 +361,38 @@ public boolean onReceivedClientCertRequest(CordovaWebView view, ICordovaClientCe
         public void onConfigurationChanged(Configuration newConfig) {
    +    /**
    +     * Called by the Plugin Manager when we need to actually request permissions
    +     *
    +     * @param requestCode   Passed to the activity to track the request
    +     *
    +     * @return              Returns the permission that was stored in the plugin
    +     */
    +    public void requestPermissions(int requestCode) {
    --- End diff --
    The design feels a bit hacky - designed around how geolocation plugin has to do this.
In fact, your changes for camera plugin for Masrhmallow don't override this method and the
`hasPermission` method. What's the guidance to a cordova plugin should they care to override
this or not?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message