cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgrebnov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-9815 Engine name="cordova" should che...
Date Sat, 17 Oct 2015 15:33:21 GMT
Github user sgrebnov commented on the pull request:

    https://github.com/apache/cordova-lib/pull/324#issuecomment-148925139
  
    @TimBarham I see your point, but all places where I saw that engine name usage all devs
thought they check cordova version - see examples below. Taking into account that we will
apply this change only in next/future cordova version where we have pinned platforms versions
lower than cordova version itself  non of existing plugins will be broken.
    
    Also, I see that this is not covere in docs at all so we may want to contribute some info
to Plugin Dev Guide 
    
    InAppBrowser plugin
    ```
        <engines>
          <engine name="cordova" version=">=3.1.0" /><!-- Needs cordova/urlutil
-->
        </engines>
    ```
    phonegap-facebook-plugin
    ```
        <engines>
            <!-- Requires > 3.3.* because of the custom Framework tag for iOS [CB-5238]
-->
            <!-- Requires > 3.5.0 because of the custom Framework tag for Android [CB-6698]
-->
            <engine name="cordova" version=">=3.5.0" />
        </engines>
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message