cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <...@git.apache.org>
Subject [GitHub] cordova-android pull request: CB-9782 Implements PlatformApi contr...
Date Fri, 16 Oct 2015 16:16:27 GMT
Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/226#discussion_r42260468
  
    --- Diff: bin/create ---
    @@ -1,49 +1,56 @@
    -#!/usr/bin/env node
    -
    -/*
    -       Licensed to the Apache Software Foundation (ASF) under one
    -       or more contributor license agreements.  See the NOTICE file
    -       distributed with this work for additional information
    -       regarding copyright ownership.  The ASF licenses this file
    -       to you under the Apache License, Version 2.0 (the
    -       "License"); you may not use this file except in compliance
    -       with the License.  You may obtain a copy of the License at
    -
    -         http://www.apache.org/licenses/LICENSE-2.0
    -
    -       Unless required by applicable law or agreed to in writing,
    -       software distributed under the License is distributed on an
    -       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    -       KIND, either express or implied.  See the License for the
    -       specific language governing permissions and limitations
    -       under the License.
    -*/
    -var path = require('path');
    -var create = require('./lib/create');
    -var argv = require('nopt')({
    -    'help' : Boolean,
    -    'cli' : Boolean,
    -    'shared' : Boolean,
    -    'link' : Boolean,
    -    'activity-name' : [String, undefined]
    -});
    -
    -if (argv.help || argv.argv.remain.length === 0) {
    -    console.log('Usage: ' + path.relative(process.cwd(), path.join(__dirname, 'create'))
+ ' <path_to_new_project> <package_name> <project_name> [<template_path>]
[--activity-name <activity_name>] [--link]');
    -    console.log('    <path_to_new_project>: Path to your new Cordova Android project');
    -    console.log('    <package_name>: Package name, following reverse-domain style
convention');
    -    console.log('    <project_name>: Project name');
    -    console.log('    <template_path>: Path to a custom application template to
use');
    -    console.log('    --activity-name <activity_name>: Activity name');
    -    console.log('    --link will use the CordovaLib project directly instead of making
a copy.');
    -    process.exit(1);
    -}
    -
    -var project_path = argv.argv.remain[0];
    -var package_name = argv.argv.remain[1];
    -var project_name = argv.argv.remain[2];
    -var template_path = argv.argv.remain[3];
    -var activity_name = argv['activity-name'];
    -
    -create.createProject(project_path, package_name, project_name, activity_name, template_path,
argv.link || argv.shared, argv.cli).done();
    -
    +#!/usr/bin/env node
    +
    +/*
    +       Licensed to the Apache Software Foundation (ASF) under one
    +       or more contributor license agreements.  See the NOTICE file
    +       distributed with this work for additional information
    +       regarding copyright ownership.  The ASF licenses this file
    +       to you under the Apache License, Version 2.0 (the
    +       "License"); you may not use this file except in compliance
    +       with the License.  You may obtain a copy of the License at
    +
    +         http://www.apache.org/licenses/LICENSE-2.0
    +
    +       Unless required by applicable law or agreed to in writing,
    +       software distributed under the License is distributed on an
    +       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +       KIND, either express or implied.  See the License for the
    +       specific language governing permissions and limitations
    +       under the License.
    +*/
    +var path = require('path');
    +var ConfigParser = require('cordova-common').ConfigParser;
    +var Api = require('./templates/cordova/Api');
    +
    +var argv = require('nopt')({
    +    'help' : Boolean,
    +    'cli' : Boolean,
    +    'shared' : Boolean,
    +    'link' : Boolean,
    +    'activity-name' : [String, undefined]
    +});
    +
    +if (argv.help || argv.argv.remain.length === 0) {
    +    console.log('Usage: ' + path.relative(process.cwd(), path.join(__dirname, 'create'))
+ ' <path_to_new_project> <package_name> <project_name> [<template_path>]
[--activity-name <activity_name>] [--link]');
    --- End diff --
    
    I did mean `events.emit`. Sounds good. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message