cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...
Date Fri, 16 Oct 2015 10:17:01 GMT
Github user daserge commented on the pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/71#issuecomment-148675826
  
    @codable, thanks for the fix!
    Can you please add a [Jira](https://issues.apache.org/jira/issues/?jql=project%20%3D%20CB%20AND%20status%20in%20%28Open%2C%20%22In%20Progress%22%2C%20Reopened%29%20AND%20text%20~%20%22uploadResponse%22)
issue and a test case?
    
    The PR and the commit title should be renamed to have CB-XXXX prefix after that.
    
    For the test I believe we will need to add another endpoint to [the file-transfer server](https://github.com/apache/cordova-labs/tree/cordova-filetransfer)
and a [corresponding Jasmine test](https://github.com/apache/cordova-plugin-file-transfer/blob/f8b0f82dfa600f2c43ce90fb44ed94d5a07c7514/tests/tests.js#L706)
ensuring non-empty response body.
    
    Also could you please sign the ICLA here: http://www.apache.org/dev/new-committers-guide.html#cla


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message