cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-plugin-file-transfer pull request: Prevent Fatal Exception...
Date Fri, 16 Oct 2015 09:11:38 GMT
Github user daserge commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/79#discussion_r42222724
  
    --- Diff: src/android/FileTransfer.java ---
    @@ -977,7 +977,11 @@ public void run() {
                             context.sendPluginResult(new PluginResult(PluginResult.Status.ERROR,
error));
                             context.aborted = true;
                             if (context.connection != null) {
    -                            context.connection.disconnect();
    +                            try{
    +                                   context.connection.disconnect();
    +                            } catch (Exception e) {                              
    +                                   Log.e(LOG_TAG, "Catch workaround for fatal exception",
e);
    --- End diff --
    
    @virix, could you please also prefix the error message with `"CB-8431"` to simplify a
potential debugging?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message