cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-plugin-file-transfer pull request: CB-9790 Align FileUploa...
Date Thu, 15 Oct 2015 15:27:51 GMT
Github user daserge commented on the pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/98#issuecomment-148422624
  
    @jason-ong, thanks!
    I've looked into the PR once more - I believe it will be better to default these values
on JS side:
    https://github.com/apache/cordova-plugin-file-transfer/blob/1142a96b2ce281fcc11b914dc21fac01eb446d9e/www/FileTransfer.js#L122-L123
    
    We could also default `fileKey` to `'file'` and `chunkedMode` to `true`.
    What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message