cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From macdonst <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-7015 Add support for parent and custo...
Date Wed, 14 Oct 2015 04:51:53 GMT
Github user macdonst commented on the pull request:

    https://github.com/apache/cordova-lib/pull/290#issuecomment-147934476
  
    I'm not in favor of this PR being merged into master as I don't think we should add the
functionality CB-7015 asks for. There is no need to add a new tag to support as the framework
tag accomplishes exactly the same functionality. Yes, this requires that your Android project
use Gradle but Gradle support for Cordova Android has been around for almost a year so it
is time to upgrade your Cordova projects to use it.
    
    It doesn't make sense to add this code that duplicates functionality for a build system
that is deprecated. If we add this code we will be responsible for testing and maintaining
it going forward.
    
    -1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message