cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgrebnov <>
Subject [GitHub] cordova-plugin-camera pull request: CB-9490 Fixed cleanup function
Date Mon, 12 Oct 2015 10:11:40 GMT
Github user sgrebnov commented on a diff in the pull request:
    --- Diff: src/android/ ---
    @@ -386,12 +387,10 @@ private void processResultFromCamera(int destType, Intent intent)
throws IOExcep
                 FileHelper.stripFileProtocol(this.croppedUri.toString()) :
    -        if (this.encodingType == JPEG) {
    -            try {
    -                //We don't support PNG, so let's not pretend we do
    -                exif.createInFile(sourcePath);
    -                exif.readExifData();
    -                rotate = exif.getOrientation();
    +            //We don't support PNG, so let's not pretend we do
    --- End diff --
    I don't think this change should be in scope of this PR (I know there is a person working
on .PNG support so this will just bring merge conflict) 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message