cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-9712 CLI 5.3 breaks with node 3.3.3
Date Thu, 08 Oct 2015 18:22:43 GMT
Github user daserge commented on the pull request:

    https://github.com/apache/cordova-lib/pull/316#issuecomment-146644694
  
    This update needs [cordova-hello-world-module to export its path](https://github.com/apache/cordova-app-hello-world/pull/14/files#diff-168726dbe96b3ce427e7fedce31bb0bcR3)
as its used in `cfg.lib.www.url` assignment directly. 
    Probably I should add a comment to this line for clearness.
    Alternatively we can use [require.resolve](https://nodejs.org/api/globals.html#globals_require_resolve)
here instead - what do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message