cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From csantanapr <>
Subject [GitHub] cordova-coho pull request: CB-9739 Prevent coho from creating brok...
Date Mon, 05 Oct 2015 22:10:33 GMT
Github user csantanapr commented on a diff in the pull request:
    --- Diff: src/create-verify-archive.js ---
    @@ -76,6 +77,49 @@ exports.createCommand = function*(argv) {
         var absOutDir = path.resolve(outDir);
         yield repoutil.forEachRepo(repos, function*(repo) {
    +        if(isWin) {
    --- End diff --
    Thanks for the clarification @daserge 
    On Mac by default using git from XCode Tools, both of the settings core.autocrlf and core.eol
are not set at all, so I would think let's leave this check only for Win as you have it here,
go ahead and merge this PR

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message