cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-9569 - Support <access> and <allow-na...
Date Mon, 05 Oct 2015 21:19:13 GMT
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-lib/pull/312#issuecomment-145671308
  
    Hmm one problem that I can see is, this assumes the last item to "clobber" the ATS entry
is the last one standing. There is no merge strategy. For example:
    ```
    <access origin="https://*.google.com />
    <access origin="https://google.com />
    ```
    
    We would only pick up the last item there, were subdomains are *not* allowed. We can't
possibly decipher the intent of the user here, it is up to the user to write a coherent whitelist
policy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message