cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-coho pull request: CB-9739 Prevent coho from creating brok...
Date Mon, 05 Oct 2015 18:42:43 GMT
Github user daserge commented on a diff in the pull request:

    https://github.com/apache/cordova-coho/pull/95#discussion_r41180911
  
    --- Diff: src/create-verify-archive.js ---
    @@ -76,6 +77,49 @@ exports.createCommand = function*(argv) {
         var absOutDir = path.resolve(outDir);
     
         yield repoutil.forEachRepo(repos, function*(repo) {
    +        if(isWin) {
    --- End diff --
    
    @csantanapr, git does not seem to change eols to CRLF on OS X given that `core.autocrlf=false`
and/or `core.eol=crlf`. It probably could be changed by [.gitattributes only (text eol=crlf)](https://help.github.com/articles/dealing-with-line-endings/).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message