cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <...@git.apache.org>
Subject [GitHub] cordova-android pull request: Cordova-Android 5.0/Marshmallow Upda...
Date Mon, 05 Oct 2015 17:18:35 GMT
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/223#discussion_r41170824
  
    --- Diff: framework/src/org/apache/cordova/CordovaPlugin.java ---
    @@ -40,6 +42,7 @@ Licensed to the Apache Software Foundation (ASF) under one
         public CordovaInterface cordova;
         protected CordovaPreferences preferences;
         private String serviceName;
    +    protected String [] permissions;
    --- End diff --
    
    I feel this is somewhat confusing. What is the derived plugin supposed to with this field?
I do not see any of the core plugins doing anything with this field. Did I miss something?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message