cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <>
Subject [GitHub] cordova-plugin-geolocation pull request: Creation of the Geolocati...
Date Mon, 05 Oct 2015 17:09:47 GMT
Github user nikhilkh commented on a diff in the pull request:
    --- Diff: src/android/ ---
    @@ -0,0 +1,97 @@
    +       Licensed to the Apache Software Foundation (ASF) under one
    +       or more contributor license agreements.  See the NOTICE file
    +       distributed with this work for additional information
    +       regarding copyright ownership.  The ASF licenses this file
    +       to you under the Apache License, Version 2.0 (the
    +       "License"); you may not use this file except in compliance
    +       with the License.  You may obtain a copy of the License at
    +       Unless required by applicable law or agreed to in writing,
    +       software distributed under the License is distributed on an
    +       KIND, either express or implied.  See the License for the
    +       specific language governing permissions and limitations
    +       under the License.
    + */
    +package org.apache.cordova.geolocation;
    +import android.Manifest;
    +import android.os.Build;
    +import org.apache.cordova.CallbackContext;
    +import org.apache.cordova.CordovaArgs;
    +import org.apache.cordova.CordovaPlugin;
    +import org.apache.cordova.PluginResult;
    +import org.apache.cordova.LOG;
    +import org.json.JSONArray;
    +import org.json.JSONException;
    +public class Geolocation extends CordovaPlugin {
    +    String TAG = "GeolocationPlugin";
    +    CallbackContext context;
    +    String [] permissions = { Manifest.permission.ACCESS_COARSE_LOCATION, Manifest.permission.ACCESS_FINE_LOCATION
    --- End diff --
    So this `permissions` is different than the base class `permissions` protected field.
Why does the base class even have a protected field? Should Geolocation plugin set the base
classes version of the field in the constructor?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message