cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-9589 auto convert IDs to new style ID...
Date Mon, 05 Oct 2015 08:49:42 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/313#discussion_r41121964
  
    --- Diff: cordova-lib/src/plugman/uninstall.js ---
    @@ -142,8 +143,17 @@ module.exports.uninstallPlugin = function(id, plugins_dir, options)
{
             var pluginInfo = pluginInfoProvider.get(depPluginDir);
             // TODO: Should remove dependencies in a separate step, since dependencies depend
on platform.
             var deps = pluginInfo.getDependencies();
    +        var deps_path;
             deps.forEach(function (d) {
    -            if (toDelete.indexOf(d.id) === -1) {
    +            var splitVersion = d.id.split('@');
    +            deps_path = path.join(plugin_dir, '..', splitVersion[0]);
    +            if (!fs.existsSync(deps_path)) {
    +                var newId = pluginMapper[splitVersion[0]];
    +                if (newId && toDelete.indexOf(newId) === -1) {
    +                   toDelete.push(newId);
    --- End diff --
    
    IMHO it makes sense to add verbose message here to show to user what's happened.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message