cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-9589 auto convert IDs to new style ID...
Date Mon, 05 Oct 2015 08:47:25 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/313#discussion_r41121721
  
    --- Diff: cordova-lib/src/plugman/install.js ---
    @@ -404,6 +418,20 @@ function installDependencies(install, dependencies, options) {
         return dependencies.reduce(function(soFar, dep) {
             return soFar.then(
                 function() {
    +                // Split @Version from the plugin id if it exists.
    +                var splitVersion = dep.id.split('@');
    +                //Check if a mapping exists for the plugin id
    +                //if it does, convert id to new name id 
    +                var newId = pluginMapper[splitVersion[0]];
    +                if(newId) {
    +                    events.emit('log', 'Notice: ' + dep.id + ' has been automatically
converted to ' + newId + ' and fetched from npm. This is due to our old plugins registry shutting
down.');
    --- End diff --
    
    Shouldn't this be emitted with `warn` level to encourage users to switch to new plugin
id instead of relying on plugin mapper?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message