cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <...@git.apache.org>
Subject [GitHub] cordova-coho pull request: CB-9739 Prevent coho from creating brok...
Date Sat, 03 Oct 2015 00:18:55 GMT
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-coho/pull/95#discussion_r41080528
  
    --- Diff: src/create-verify-archive.js ---
    @@ -76,6 +77,49 @@ exports.createCommand = function*(argv) {
         var absOutDir = path.resolve(outDir);
     
         yield repoutil.forEachRepo(repos, function*(repo) {
    +        if(isWin) {
    --- End diff --
    
    We only have evidence of a problem with committers using Windows machine. In theory, this
could happen on a Linux/mac machine - but the defaults ensure that this does not happen. Unless
this is trivial - I would like us to move forward with getting this fix in for Windows.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message