cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-ios pull request: CB-9719 set enable_modules build setting...
Date Fri, 02 Oct 2015 19:13:09 GMT
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-ios/pull/170#issuecomment-145129095
  
    LGTM. 
    However, the side effect of this is, if any modules use the module import syntax, ie `@import
UIKit;` this might break I think, but the workaround there is to use the old import method,
so its fine.
    
    The final fix would be to make CordovaLib as a module, but that's a lot more work potentially.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message