cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-9569 - Support <access> and <allow-na...
Date Fri, 02 Oct 2015 07:14:24 GMT
Github user vladimir-kotikov commented on the pull request:

    https://github.com/apache/cordova-lib/pull/312#issuecomment-144940986
  
    They fails because of facebook plugin has changed its id: https://github.com/Wizcorp/phonegap-facebook-plugin/commit/a2f6dbb80a54eff29a0e09836aebf0dd905fd60a
and we [still use old id](https://github.com/apache/cordova-lib/blob/master/cordova-lib/spec-cordova/save.spec.js#L52)
in our tests to check if the plugin's variables saved into config.xml


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message