Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4DA7117433 for ; Thu, 10 Sep 2015 21:26:50 +0000 (UTC) Received: (qmail 18122 invoked by uid 500); 10 Sep 2015 21:26:50 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 18081 invoked by uid 500); 10 Sep 2015 21:26:50 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 18049 invoked by uid 99); 10 Sep 2015 21:26:49 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Sep 2015 21:26:49 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 51C4AC0233 for ; Thu, 10 Sep 2015 21:26:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.15 X-Spam-Level: *** X-Spam-Status: No, score=3.15 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, HTML_MESSAGE=3, RCVD_IN_MSPIKE_H2=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id FyOmF4Eo03_h for ; Thu, 10 Sep 2015 21:26:39 +0000 (UTC) Received: from mail-vk0-f43.google.com (mail-vk0-f43.google.com [209.85.213.43]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with ESMTPS id 2806344573 for ; Thu, 10 Sep 2015 21:26:39 +0000 (UTC) Received: by vkgd64 with SMTP id d64so16928131vkg.0 for ; Thu, 10 Sep 2015 14:26:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-type; bh=PU267bn/P+gB7pJM5d8wUeRAtfiX6tBfwHCnjcI7gis=; b=gl6OUqLTXVmkrFqEhh1nebgcKeEqJ5wyTPt6XG95qUlBhgFBvfHqsctthvA6kUgYZ4 kMxUfnSwspvvSAA4VJLUv/FPkSz1CzOp44TxDpduRVe2CbXv28LptIF3xCsySK1CXVqo CvzZ30yvMD/zaS4W6PeCP20y0IRdzoOLoDBua3s28Dg45+oNS2Uj0ybW3uh4OIGHDx2E DrhEv/SjneA9dOaYTghulSVLhz/8hzQD9JbXPo29F0F5asbxFSCfIaNF86dUCR0ElGQp tfoGw/RFqre7arsh1FXZ9uKLpsPrU9ztrBrCkHPGmIQU9KN13PfxcrO000giir92kCtK v3IQ== X-Received: by 10.31.56.150 with SMTP id f144mr2373864vka.122.1441920398838; Thu, 10 Sep 2015 14:26:38 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Carlos Santana Date: Thu, 10 Sep 2015 21:26:29 +0000 Message-ID: Subject: Re: going to merge PR #39 for globalization plugin ? To: "dev@cordova.apache.org" Content-Type: multipart/alternative; boundary=001a1143fde02acf9a051f6b4121 --001a1143fde02acf9a051f6b4121 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable yup, that's what I always reference, and try to update as need it as I find things On Thu, Sep 10, 2015 at 4:42 PM Nikhil Khandelwal wrote: > Would be great to have some help in merging pending PRs. There are lots o= f > them pending. [1] > > This is a good guide on this for committers: > https://github.com/apache/cordova-coho/blob/master/docs/processing-pull-r= equests.md > > Thanks, > Nikhil > > [1] http://s.apache.org/cordovaPulls > > -----Original Message----- > From: Shazron [mailto:shazron@gmail.com] > Sent: Thursday, September 10, 2015 11:06 AM > To: dev@cordova.apache.org > Subject: Re: going to merge PR #39 for globalization plugin ? > > I'm too lazy as well, too much to do :/ looks like you have to do it. > Merge it no need to ask permission, dear core committer :) > > On Thursday, September 10, 2015, Carlos Santana > wrote: > > > Any objections for me to merge PR #39 [1] ? > > I'm going to review it again, and merge if it looks good. > > > > Also I see that there are other 5 PRs, dating back to Aug 28, 2014 ouch > !! > > > > Was thinking on giving some love to the plugin and handle the other > > PRs also, what you guys think? > > > > Anyone knows if some of these PRs are already merged, and just open > > can't be close with a git comment? I'm too lazy to check :-p if > > someone can give me the answer quickly > > > > [1]: > > > https://na01.safelinks.protection.outlook.com/?url=3Dhttps%3a%2f%2fgithub= .com%2fapache%2fcordova-plugin-globalization%2fpull%2f39&data=3D01%7c01%7cn= ikhilkh%40microsoft.com%7c4f072382eacb4d1a461108d2ba0a7b52%7c72f988bf86f141= af91ab2d7cd011db47%7c1&sdata=3DfZTeBpO14TWnXOsWyBIRlAhLHyAGrXSUr3TOqTNYCQk%= 3d > > > --001a1143fde02acf9a051f6b4121--