Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C3F0918E58 for ; Wed, 16 Sep 2015 17:15:31 +0000 (UTC) Received: (qmail 98606 invoked by uid 500); 16 Sep 2015 17:15:31 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 98568 invoked by uid 500); 16 Sep 2015 17:15:31 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 98554 invoked by uid 99); 16 Sep 2015 17:15:31 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Sep 2015 17:15:31 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 17608E0243; Wed, 16 Sep 2015 17:15:31 +0000 (UTC) From: theaccordance To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-lib pull request: Cb-8789 Content-Type: text/plain Message-Id: <20150916171531.17608E0243@git1-us-west.apache.org> Date: Wed, 16 Sep 2015 17:15:31 +0000 (UTC) Github user theaccordance commented on the pull request: https://github.com/apache/cordova-lib/pull/261#issuecomment-140809045 Apologies on the tests; I'll make sure to acquaint myself with the testing suite and update tests for further contributions. Related note to this PR: There's a corresponding [PR in the cordova-lib project](https://github.com/apache/cordova-lib/pull/261) that also needs to be reviewed and accepted. That PR updates the process of copying icon/launch image assets into the xcode project to match the changes applied with this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org