cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fatty1380 <...@git.apache.org>
Subject [GitHub] cordova-plugin-geolocation pull request: Prevent API Deprecation W...
Date Wed, 02 Sep 2015 20:51:00 GMT
GitHub user fatty1380 opened a pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/48

    Prevent API Deprecation Warnings thru pre-processor macros

    I've wrapped the call to `locationServicesEnabled` which is causing a Deprecation warning
under compilation, in a `#ifndev __IPHONE_4_0` preprocessor macro. 
    
    The better solution would be to drop any code that accommodates devices that old, but
I'll start here.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fatty1380/cordova-plugin-geolocation patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-geolocation/pull/48.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #48
    
----
commit 0027efc8de4840651d03a68c9aa7d4445c201154
Author: Patrick Fowler <pfowler@cs.stanford.edu>
Date:   2015-09-02T20:50:16Z

    Prevent API Deprecation Warnings thru pre-processor macros
    
    I've wrapped the call to `locationServicesEnabled` which is causing a Deprecation warning
under compilation, in a `#ifndev __IPHONE_4_0` preprocessor macro. 
    
    The better solution would be to drop any code that accommodates devices that old, but
I'll start here.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message