cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From limefrogyank <...@git.apache.org>
Subject [GitHub] cordova-plugin-media-capture pull request: Orientation fixes for W...
Date Sun, 27 Sep 2015 17:23:34 GMT
GitHub user limefrogyank opened a pull request:

    https://github.com/apache/cordova-plugin-media-capture/pull/47

    Orientation fixes for WP81 and orientation lock when recording video.

    I'm using the media-capture plugin on wp81 (universal build) and I decided to fix the
orientation problems.  When you enter the capture page, it will now check the device orientation
and rotate both the preview and record settings according to the current orientation.  An
event handler has been attached for changes in orientation which again update the preview
and record settings. 
    
    When recording is in progress, the orientation is *locked*.  As soon as the recording
is shut down, the orientation returns to no preference and the event handler is removed. 
Seems to work fine for me.
    
    Next I'd like to fix the cancel button and the hardware back button.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/limefrogyank/cordova-plugin-media-capture master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media-capture/pull/47.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #47
    
----
commit 757c4c12ed8fe9df22ee68564fff40f6f5c6336b
Author: limefrogyank <leemcpherson@hotmail.com>
Date:   2015-09-27T17:16:39Z

    Orientation fixes for WP81 and orientation lock when recording video.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message