cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-9598 Switching to use `cordova-common...
Date Wed, 30 Sep 2015 14:43:39 GMT
GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-lib/pull/311

    CB-9598 Switching to use `cordova-common` module

    See [CB-9598](https://issues.apache.org/jira/browse/CB-9598) for details.
    
    This PR just removes code which has been copied previously to `cordova-common` and updates
requires to point to that code. The LIB  includes `cordova-common`  as a bundled dependency,
so it doesn't need to be published.
    
    To npm links to new module could be set up using `coho npm-link` after pulling in the
following PR to cordova-coho: https://github.com/apache/cordova-coho/pull/94

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-lib CB-9598

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/311.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #311
    
----
commit 4c7bcc84a4ef96d84df968ac30c06b70945ef1b1
Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
Date:   2015-09-30T13:24:06Z

    CB-9598 Cleans out code which has been moved to `cordova-common`

commit a15f049f9882935f7426e23cfe409841ab9ae722
Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
Date:   2015-09-30T14:43:04Z

    CB-9598 Switches LIB to use `cordova-common`
    
    * Updates requires to point to `cordova-common`
    * Add 'cordova-common' as bundled dependency

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message