cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fatty1380 <...@git.apache.org>
Subject [GitHub] cordova-ios pull request: Prevent Compilation Warning : Conflictin...
Date Wed, 02 Sep 2015 21:00:02 GMT
GitHub user fatty1380 opened a pull request:

    https://github.com/apache/cordova-ios/pull/157

    Prevent Compilation Warning : Conflicting Return Type

    The `supportedInterfaceOrientationsForWindow` method currently returns a value of type
`NSUInteger`. This causes a warning in the Xcode console: 
    > Conflicting return type in implementation of 'application:supportedInterfaceOrientationsForWindow:':
'UIInterfaceOrientationMask' (aka 'enum UIInterfaceOrientationMask') vs 'NSUInteger' (aka
'unsigned long')
    
    This change updates the return type to be `UIInterfaceOrientationMask` rather than `NSUInteger`
to avoid the warning

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fatty1380/cordova-ios patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/157.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #157
    
----
commit cfe9ad7ef646d974abcf93e56b6ee27bab589435
Author: Patrick Fowler <pfowler@cs.stanford.edu>
Date:   2015-09-02T20:59:55Z

    Prevent Compilation Warning : Conflicting Return Type
    
    The `supportedInterfaceOrientationsForWindow` method currently returns a value of type
`NSUInteger`. This causes a warning in the Xcode console: 
    > Conflicting return type in implementation of 'application:supportedInterfaceOrientationsForWindow:':
'UIInterfaceOrientationMask' (aka 'enum UIInterfaceOrientationMask') vs 'NSUInteger' (aka
'unsigned long')
    
    This change updates the return type to be `UIInterfaceOrientationMask` rather than `NSUInteger`
to avoid the warning

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message