cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steven Gill <stevengil...@gmail.com>
Subject Re: cordova-plugin-whitelist ios issue
Date Wed, 30 Sep 2015 19:25:21 GMT
I can change whitelist back to version 1 which only has the engine check
for android. I can do that now if everyone is okay with it. We can change
it back once cordova-ios@4 releases.

On Wed, Sep 30, 2015 at 12:13 PM, Shazron <shazron@gmail.com> wrote:

> -1.
> We can just update the dist-tag so @latest goes to a previous version.
> All released versions have been voted on, so its a matter of dist-tag
> carousel.
>
>
>
> On Tue, Sep 29, 2015 at 7:31 PM, Carlos Santana <csantana23@gmail.com>
> wrote:
> > In summary I proposed that we update the plugin with a version that only
> > contains the android code.
> > When we publish cordova-ios@4.0.0 then we publish a new version that
> > contains the ios code and contains engine tag stating that it needs
> minimum
> > cordova-ios@4.0.0
> >
> > I'm OK if you want to have two branches to make it clear to devs, 1.x it
> > contains android only, branch 2.x contains both android and ios.
> >
> >
> > On Tue, Sep 29, 2015 at 10:26 PM Carlos Santana <csantana23@gmail.com>
> > wrote:
> >
> >> Here are my two cents, and I'm aware of the situation.
> >>
> >> publish a new version of cordova-plugin-whitelist  that only contains
> the
> >> android code and only supports android platform (means to remove any ios
> >> code from the plugin)
> >>
> >> Currently the plugin is public and published on npm as latest, and it
> >> states in the README:
> >>
> >>    - Android 4.0.0 or above
> >>    - iOS 4.0.0 or above
> >>
> >> Guess what iOS 4.0.0 is it doesn't exist, it's not out, it's not born
> yet.
> >> I guess you get the picture. The day that cordova-ios@4.0.0 get's
> >> published to npm is the day that it exist, then is valid to published
> >> plugins that depend on that version of the platform.
> >>
> >> The day we published cordova-ios@4.0.0 to npm, on the same day we
> publish
> >> cordova-plugin-whitelist that has code for ios and depends on
> >> cordova-ios@4.0.0
> >>
> >> In general to my eyes we should NOT published plugins that depends (i.e.
> >> engines) depend on a version of a component that it's not born yet.
> >>
> >>
> >>
> >> On Tue, Sep 29, 2015 at 8:57 PM Shazron <shazron@gmail.com> wrote:
> >>
> >>> This has nothing to do with cordova-ios being released. Think of it
> >>> solely by the plugin's requirements: it requires cordova-android 4,
> >>> and cordova-ios 4. I have cordova-android 4, so it installs. I have
> >>> cordova-ios 3.9 so it doesn't, and it warns me.
> >>>
> >>> We *will* have this problem later with plugins, guaranteed, we should
> >>> not try to hide this problem for our own convenience.
> >>>
> >>> Let's say we took out this engine requirement, and they installed the
> >>> plugin on cordova-ios 3.9. Hey the warning goes away, great! But this
> >>> is a huge problem, because the code will be installed and it wasn't
> >>> meant for your platform, and will probably cause bugs. It is dependent
> >>> of a platform version for a reason.
> >>>
> >>>
> >>> On Tue, Sep 29, 2015 at 5:49 PM, Shazron <shazron@gmail.com> wrote:
> >>> > I don't agree.
> >>> >
> >>> > I still don't think you understand the issue. I realize you want to
> >>> > get "rid of the warnings" but there is really nothing to fix. Nothing
> >>> > at all. Users do not have to do anything, you don't have to do
> >>> > anything.
> >>> >
> >>> > If they have cordova-ios 3.x installed - ignore this warning. This
> >>> > plugin wasn't meant for your platform.
> >>> >
> >>> >
> >>> >
> >>> > On Tue, Sep 29, 2015 at 5:37 PM, Nikhil Khandelwal
> >>> > <nikhilkh@microsoft.com> wrote:
> >>> >> I think the first version of the whitelist plugin was released
> without
> >>> the corodva-ios 4.0 check, so that developers do not see this warning
> >>> because cordova-ios 4.0 was not released. I agree with Tommy, that the
> >>> wording of the warning seems to suggest there is a way for me to fix
> this
> >>> issue:
> >>> >> "Plugin doesn't support this project's cordova-ios version.
> >>> cordova-ios: 3.9.1, failed version requirement: >=4.0.0-dev."
> >>> >>
> >>> >> However, with this plugin we do not have a way to fix it because
ios
> >>> 4.0 is not released.
> >>> >>
> >>> >> I suggest we do the following:
> >>> >> - Unpublish the version that has a dependency on ios 4.x
> >>> >> - Release cordova-plugin-whitelist v2 which has an ios 4.x depdency
> >>> >> - In the tools release, that pins cordova-ios 4.x we should ship
a
> >>> cordova-app-hello-world template that targets v2 of this plugin.
> >>> >>
> >>> >> Thanks,
> >>> >> Nikhil
> >>> >>
> >>> >> -----Original Message-----
> >>> >> From: Shazron [mailto:shazron@gmail.com]
> >>> >> Sent: Tuesday, September 29, 2015 5:28 PM
> >>> >> To: dev@cordova.apache.org
> >>> >> Subject: Re: cordova-plugin-whitelist ios issue
> >>> >>
> >>> >> This is only happening because we have two engine requirements
-
> >>> cordova-android 4.x and cordova-ios 4.x. This is correct for
> >>> cordova-plugin-whitelist.
> >>> >>
> >>> >> Like I mentioned before, cordova-android+ios 3.x *do not* require
> this
> >>> plugin as it is built in. Perhaps this could be communicated better,
> but
> >>> the warning is generic, and there's no way to communicate this in an
> >>> <engine> tag.
> >>> >>
> >>> >> We could release core plugins that have different core platform
> >>> version requirements as well in the future (like android 5 plugin
> >>> >> changes) and this will occur again.
> >>> >>
> >>> >>
> >>> >> On Tue, Sep 29, 2015 at 5:21 PM, Shazron <shazron@gmail.com>
wrote:
> >>> >>> "IMO we should never release a plugin which always emits a
warning
> >>> >>> that cannot be resolved."
> >>> >>>
> >>> >>> There is nothing to resolve. The resolution is to ignore it.
It's
> >>> >>> supposed to warn you, as it is working as expected.
> >>> >>>
> >>> >>> On Tue, Sep 29, 2015 at 5:19 PM, Nikhil Khandelwal
> >>> >>> <nikhilkh@microsoft.com> wrote:
> >>> >>>> I understand the warning w.r.t. plugins and android 5.0
as we will
> >>> release android 5.0 along with the plugin update and there would be a
> path
> >>> for people to resolve the warning.
> >>> >>>>
> >>> >>>> In this case, ios 4.0 is not even released and users have
no way
> to
> >>> work around this warning. We're getting feedback from customers about
> this.
> >>> >>>>
> >>> >>>> IMO we should never release a plugin which always emits
a warning
> >>> that cannot be resolved.
> >>> >>>>
> >>> >>>> -Nikhil
> >>> >>>>
> >>> >>>> -----Original Message-----
> >>> >>>> From: Shazron [mailto:shazron@gmail.com]
> >>> >>>> Sent: Tuesday, September 29, 2015 5:17 PM
> >>> >>>> To: dev@cordova.apache.org
> >>> >>>> Subject: Re: cordova-plugin-whitelist ios issue
> >>> >>>>
> >>> >>>> No its not a "rogue version". cordova-plugin-whitelist
requires
> >>> cordova-ios 4.0 and cordova-android 4.0.
> >>> >>>> It's just a warning and is expected to work this way.
> >>> >>>>
> >>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgith
> >>> >>>> ub.com
> >>> %2fapache%2fcordova-plugin-whitelist%2fblob%2fmaster%2fREADME.m
> >>> >>>> d&data=01%7c01%7cnikhilkh%40microsoft.com
> >>> %7cd638675115ae4fa7be2d08d2c
> >>> >>>>
> 92c9d89%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=iO9NDS0BgD53OVED
> >>> >>>> yxGv0zNW5SKXLVK0loo8ZAEmfOM%3d
> >>> >>>>
> >>> >>>> On Tue, Sep 29, 2015 at 5:08 PM, Nikhil Khandelwal <
> >>> nikhilkh@microsoft.com> wrote:
> >>> >>>>> 1.       cordova create test
> >>> >>>>>
> >>> >>>>> 2.       cordova platform add ios
> >>> >>>>>
> >>> >>>>> WARNING: Applications for platform ios can not be built
on this
> OS
> >>> - win32.
> >>> >>>>> Adding ios project...
> >>> >>>>> iOS project created with cordova-ios@3.9.1 Discovered
plugin
> >>> >>>>> "cordova-plugin-whitelist" in config.xml. Installing
to the
> project
> >>> >>>>> Fetching plugin "cordova-plugin-whitelist@1" via npm
Installing
> >>> >>>>> "cordova-plugin-whitelist" for ios Plugin doesn't support
this
> >>> >>>>> project's cordova-ios version. cordova-ios: 3.9.1,
failed version
> >>> >>>>> requirement: >=4.0.0-dev Skipping 'cordova-plugin-whitelist'
for
> ios
> >>> >>>>> Installing "cordova-plugin-whitelist" for ios Plugin
doesn't
> support
> >>> >>>>> this project's cordova-ios version. cordova-ios: 3.9.1,
failed
> >>> >>>>> version
> >>> >>>>> requirement: >=4.0.0-dev Skipping 'cordova-plugin-whitelist'
for
> ios
> >>> >>>>>
> >>> >>>>> Looks like we have a rogue version of cordova-plugin-whitelist
> >>> published that requires iOS 4.0.0. What's the best way to fix it? Can
> we
> >>> unpublish this whitelist plugin version from npm to fix this?
> >>> Alternatively, we should release another version of the plugin that
> does
> >>> not get this warning. It's misleading and confusing for developers to
> see
> >>> this warning.
> >>> >>>>>
> >>> >>>>> Thanks,
> >>> >>>>> Nikhil
> >>> >>>>
> >>> >>>>
> ---------------------------------------------------------------------
> >>> >>>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >>> >>>> For additional commands, e-mail: dev-help@cordova.apache.org
> >>> >>>>
> >>> >>>>
> >>> >>>>
> ---------------------------------------------------------------------
> >>> >>>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >>> >>>> For additional commands, e-mail: dev-help@cordova.apache.org
> >>> >>
> >>> >>
> ---------------------------------------------------------------------
> >>> >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >>> >> For additional commands, e-mail: dev-help@cordova.apache.org
> >>> >>
> >>> >>
> >>> >>
> ---------------------------------------------------------------------
> >>> >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >>> >> For additional commands, e-mail: dev-help@cordova.apache.org
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >>> For additional commands, e-mail: dev-help@cordova.apache.org
> >>>
> >>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message