cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nikhil Khandelwal <nikhi...@microsoft.com>
Subject RE: Marshmallow Update and Cordova-Android 5.0
Date Wed, 09 Sep 2015 04:15:58 GMT
It would be great to add this platform matrix to our buildbot CI. Any volunteers?

-Nikhil

-----Original Message-----
From: Karen Tran [mailto:ktop500@gmail.com] 
Sent: Monday, September 7, 2015 7:32 PM
To: dev@cordova.apache.org
Subject: Re: Marshmallow Update and Cordova-Android 5.0

I tested your camera plugin through mobilespec and the permissions are working.

On Thu, Sep 3, 2015 at 12:10 PM, Joe Bowser <bowserj@gmail.com> wrote:

> On Thu, Sep 3, 2015 at 8:07 AM Karen Tran <ktop500@gmail.com> wrote:
>
> > Hi Joe,
> >
> > I tested your patch and it works for the most part using 
> > mobilespec's manual test for contacts. I do see the prompt for 
> > permissions contacts,
> but
> > not explicitly to read or write contacts like you mentioned.
> >
> > I don't either, even though I'm explicitly promoting for the permission.
> Also, I found that if you prompt for READ permissions, you get both 
> READ and WRITE.
>
>
> > One thing that doesn't work is if you click "Deny" permission, the 
> > app crashes. I don't think we'd want that to happen, so we'll have 
> > to handle that case.
> >
>
> It should work now.  I forgot to return out of the method once the 
> permission is denied.
>
>
> >
> > And as for the contact autotests, they're a bit finicky now with a 
> > couple of failures.
> >
>
> Contacts has always been finicky, and needs a full re-write.  I wasn't 
> intending to fully fix this plugin (because of time), just get the 
> permissions working because it's the low hanging fruit.  Any change to 
> the flow of the tests will break the tests because of concurrency 
> issues with the Android Contacts API.
>
> I also have the Camera using the plugin, since we rely on external 
> storage for determining whether we're going to produce duplicates.
>
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu
> b.com%2finfil00p%2fcordova-plugin-camera%2ftree%2fsmores&data=01%7c01%
> 7cnikhilkh%40microsoft.com%7c30099748db0849137b6b08d2b7f5b4e5%7c72f988
> bf86f141af91ab2d7cd011db47%7c1&sdata=HQYKeY5Xnkqpr0xnwsNH8wGvtNduDAl59
> FUYbH7WQHo%3d
>
>
>
> > On Tue, Sep 1, 2015 at 9:39 AM, Carlos Santana 
> > <csantana23@gmail.com>
> > wrote:
> >
> > > Joe I understand the feeling. One part of me saying that we should 
> > > name
> > the
> > > version 4.2 since there are no API changes.
> > > But my other part says that if developer's ignore because is 4.x 
> > > stuff
> > will
> > > break in new major release of Android M (23)
> > >
> > > I would say that also agree that best option is to name is
> > > cordova-android@5
> > > , then is clear to developers that they can use targetsdk=23 and 
> > > also
> new
> > > major versions for the affected plugins that need updates to 
> > > support
> > > targetsdk=23
> > >
> > > But as you can see this is less important that getting the plugins 
> > > to
> > work
> > > correctly with permissions :-)
> > >
> > >
> > >
> > > On Tue, Sep 1, 2015 at 12:03 AM Joe Bowser <bowserj@gmail.com> wrote:
> > >
> > > > BTW: I got Contacts somewhat working with Marshmellow.  It's 
> > > > still
> got
> > > the
> > > > same crappy concurrency bugs that it always has, and I am not 
> > > > sure
> how
> > to
> > > > resolve those without re-writing the damn thing, but the purpose 
> > > > of
> > this
> > > is
> > > > to figure out how to get permissions to work, and I have 
> > > > something
> that
> > > > works.
> > > >
> > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2
> > > > fgithub.com%2finfil00p%2fcordova-plugin-contacts%2ftree%2fsmores
> > > > &data=01%7c01%7cnikhilkh%40microsoft.com%7c30099748db0849137b6b0
> > > > 8d2b7f5b4e5%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=c9deJEn
> > > > 9QG4vSDvqCMhBH%2f7r6RyBjitCYeMUtlXC4WE%3d
> > > >
> > > > This works with the latest smores tree of Cordova Android, and I
> tested
> > > it
> > > > on Lollipop and Marshmellow.  I'm going to move on to some of 
> > > > the
> other
> > > > plugins to get them ready for Marshmellow, but it'd be good to 
> > > > have
> > > people
> > > > look these over.
> > > >
> > > > I did find a nasty security bug with this, though.  If you 
> > > > request
> one
> > > > permission out of the permission group, you get all the permissions.
> > So,
> > > > anything that can read contacts can magically write contacts 
> > > > even if
> > you
> > > > don't request that permission explicitly.  I think this is a 
> > > > serious
> > bug,
> > > > and I'm going to dig tomorrow to see if someone already reported it.
> > > >
> > > > On Mon, Aug 31, 2015 at 11:35 AM Joe Bowser <bowserj@gmail.com>
> wrote:
> > > >
> > > > > Hey
> > > > >
> > > > > So, I created a new topic branch of my github with the new 
> > > > > changes
> as
> > > > > suggested earlier.
> > > > >
> > > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f
> > > > > %2fgithub.com%2finfil00p%2fcordova-android%2ftree%2fsmores&dat
> > > > > a=01%7c01%7cnikhilkh%40microsoft.com%7c30099748db0849137b6b08d
> > > > > 2b7f5b4e5%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=F9HVQbi
> > > > > 0riRRjfDZqQUvQ5pjK29ky3WZcGueYGt%2fRMY%3d
> > > > >
> > > > > The thing we have to make sure works is if the user turns off 
> > > > > the permissions on Marshmellow.  Right now if the permissions 
> > > > > are off, everything crashes and dies, so we're going to issue 
> > > > > a 5.0 because
> > > > plugins
> > > > > will have to have this code to work on the latest version of
> Android.
> > > > It's
> > > > > not a API change, since we're adding it, but I feel that it's
> > important
> > > > > enough that we should bump the major version anyway.
> > > > >
> > > > > Can we PLEASE not have any other features creep into 5.0?  If 
> > > > > we
> need
> > > > > additional features, we can do a 6.0.  I'm not against bumping
> major
> > > > > versions as long as we get into a trend of not breaking shit 
> > > > > like
> we
> > > did
> > > > in
> > > > > the bump from 3.7 to 4.0.
> > > > >
> > > > > Also, we're going to deprecate 3.7, is there any major 
> > > > > third-party
> > > > plugins
> > > > > that still don't work with 4.0.x that we should be aware of?  
> > > > > Do we
> > > have
> > > > > people to cover the docs on that.
> > > > >
> > > > > Thoughts?
> > > > >
> > > > > Joe
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
>
Mime
View raw message