cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nikhil Khandelwal <nikhi...@microsoft.com>
Subject RE: cordova-plugin-whitelist ios issue
Date Wed, 30 Sep 2015 17:49:34 GMT
I'm up for a hangout on this subject. I do think e-mail is making it hard to communicate this.
I am with Carlos - we should not have warnings that cannot be resolved for unreleased platform
versions. This is particularly, a problem for a new web developer to Cordova who does not
understand the history of whitelist and the user of it and is confronted with it upfront.
There is not the first time this feedback has been voiced. [1][2]

Carlos does raise some other important concerns. I've heard a lot of confusion from Cordova
devs on whitelist changes. This is especially painful for Android 4.0 which has no network
access without whitelist. I think we are making better defaults (of having network access)
 with Cordova IOS 4.0. Perhaps we should change the behavior for Android with Android 5.0.

-Nikhil

[1] https://github.com/apache/cordova-plugin-whitelist/commit/72a067c96e4e54efb8f1f152220d4a5fdf404324#commitcomment-11624636
[2] http://callback.markmail.org/thread/w2pjyndljbdng23f

-----Original Message-----
From: Carlos Santana [mailto:csantana23@gmail.com] 
Sent: Wednesday, September 30, 2015 9:03 AM
To: dev@cordova.apache.org
Subject: Re: cordova-plugin-whitelist ios issue

People are already getting surprised today that their apps do not connect to any network when
they create an app that contains cordova-android@4.x because the whitelist plugin is not included
by default.
Why whitelist is not included by default?
- the don't use the cordova-cli, the use cordova-android/bin/create (shell
mode)
- because they use their own templates, for example I created an app with my own template
that has my config.xml that doesn't have whitelist plugin because I created the template in
the cordova-android@3.x time frame.
- people creating apps with other CLIs, for example ionic cli, whitelist plugin is not one
of the default plugins added with their ionic templates, etc..


On Wed, Sep 30, 2015 at 11:48 AM Carlos Santana <csantana23@gmail.com>
wrote:

> So this mean I can add this engine tag today to the whitelist plugin 
> with some code specific to firefoxos?
>  <engine name="cordova-firefoxos" version=">=4.0.0-dev" />
>
> I know cordova-firefoxos@4.0.0-dev or ordova-firefoxos@4.0.0 is not on 
> npm but is very useful to give users the warning now.
> This will avoid the user from upgrading the plugin ever in the future 
> when
> cordova-firefoxos@4.0.0 is published to npm, I might get c
> ordova-firefoxos@4.0.0 around december or longer  so I don't think it 
> will be a problem for them to see the warning until then.
>
> If everyone is OK I will put this code today? this will avoid user 
> from having to upgrade the plugin in the future :-p
>
> This is the point I want to make, and guess email communication is not 
> being our friend to express my point of view.
> Will those interested on this topic up for a quick Hangout? Simon, 
> Shaz, Nikhil
>
>
> On Wed, Sep 30, 2015 at 10:55 AM Simon MacDonald < 
> simon.macdonald@gmail.com> wrote:
>
>> -1 to this proposal IMHO
>>
>> Warnings are useful. If someone sees this and is confused as to why 
>> there is a new whitelist plugin then looks into it some more detail 
>> that will be beneficial. I think the warning should be more explicit. 
>> Put an info tag into the plugin.xml for the whitelist linking to the 
>> docs and what the upcoming change is in cordova-ios 4.0.0. That way people will be
"less"
>> surprised that they need to install this plugin in the future.
>>
>>
>>
>> Simon Mac Donald
>> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im
>> %2fsimonmacdonald&data=01%7c01%7cnikhilkh%40microsoft.com%7caa884ed39
>> 282462add6208d2c9b0f4ab%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=
>> NW%2bD7WmSnLFc9L9nYI6Q%2fabIiY6GjTci8x49Tsve%2biw%3d
>>
>> On Tue, Sep 29, 2015 at 11:35 PM, Tommy Williams <tommy@devgeeks.org>
>> wrote:
>>
>> > This.
>> >
>> > +1
>> >
>> >
>> > On 30 September 2015 at 12:31:29, Carlos Santana 
>> > (csantana23@gmail.com)
>> > wrote:
>> >
>> > In summary I proposed that we update the plugin with a version that 
>> > only contains the android code.
>> > When we publish cordova-ios@4.0.0 then we publish a new version 
>> > that contains the ios code and contains engine tag stating that it 
>> > needs minimum
>> > cordova-ios@4.0.0
>> >
>> > I'm OK if you want to have two branches to make it clear to devs, 
>> > 1.x it contains android only, branch 2.x contains both android and ios.
>> >
>>
>
Mime
View raw message