cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request: Return rawId
Date Tue, 29 Sep 2015 18:01:02 GMT
Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/68#issuecomment-144136865
  
    Hey @manugb 
    Sorry for the delay in looking at this. Can you point to where it says rawId should be
returned, or explain why?  Looking at the code, it is very hard to tell, but it seems create
is returning an id, and not a rawId, and save is calling either create||modify so it seems
they should both return the same type of id.
    
    Also, it would be great if we could have a test added that proves this error exists, and
also that this pr fixes it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message