cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <...@git.apache.org>
Subject [GitHub] cordova-android pull request: Current Cordova-Android 5.0 changes.
Date Thu, 24 Sep 2015 23:43:34 GMT
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/220#discussion_r40386760
  
    --- Diff: framework/src/org/apache/cordova/CordovaInterface.java ---
    @@ -69,4 +69,7 @@ Licensed to the Apache Software Foundation (ASF) under one
          * Returns a shared thread pool that can be used for background tasks.
          */
         public ExecutorService getThreadPool();
    +
    +    public void requestPermission(CordovaPlugin plugin, int requestCode, String permission);
    --- End diff --
    
    JavaDoc would be great here - since this is public API. Eventually we should figure out
how to publish the public API docs online. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message