cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dblotsky <...@git.apache.org>
Subject [GitHub] cordova-medic pull request: CB-8936 Tweaking windows log gathering...
Date Tue, 22 Sep 2015 19:20:41 GMT
Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/64#discussion_r40131491
  
    --- Diff: medic/medic-log.js ---
    @@ -63,10 +63,14 @@ function logIOS() {
         });
     }
     
    -function logWindows() {
    +function logWindows(timeout) {
         var logScriptPath = path.join("mobilespec", "platforms", "windows", "cordova", "log.bat");
         if (fs.existsSync(logScriptPath)) {
    -        shelljs.exec(logScriptPath + " --dump --mins 15", function (code, output) {
    +        var mins = 15;
    +        if (timeout) {
    +            mins = Math.ceil(timeout / 60);
    --- End diff --
    
    A few notes:
    - Please add a small constant (~2 min) to the time so that we also capture anything that
happened before the run
    - Please factor out the default 15 mins into a constant
    - Please add a function to convert minutes to seconds, so it's easier to read (i.e. `mins
= sec2min(timeout)`)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message