cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgrebnov <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: CB-9490 Fixed cleanup function
Date Mon, 14 Sep 2015 09:30:52 GMT
Github user sgrebnov commented on the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-140016250
  
    @cojomojo the fix makes perfect sense, but I see that the code you use is very similar
to what we have in `checkForDuplicateImage` and looks like that function is not required anymore
(as I think you cover that case) so I propose to rename `checkForDuplicateImage` to `removeTemporaryImages`
(or `cleanupTempImages`) and move your logic there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message