cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TimBarham <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-9617 Do not restore plugins immediate...
Date Thu, 10 Sep 2015 08:03:56 GMT
Github user TimBarham commented on the pull request:

    https://github.com/apache/cordova-lib/pull/304#issuecomment-139157987
  
    It seems like an ok fix for the immediate problem, but it does raise a concern in my mind
- before the Platform API changes, we didn't call `prepare` when adding/removing plugins.
This meant we didn't call `installPluginsFromConfigXML()` even when *adding* a plugin.
    
    So, I have a question: is it perhaps overkill to call `prepare()` when adding/removing
plugins? We end up doing a bunch of stuff we didn't used to do - such as calling `installPluginsFromConfigXML()`,
calling `installPlatformsFromConfigXML()`, firing `before_prepare` and `after_prepare` hooks.
Maybe other stuff? Is this desirable, or should we only be calling a subset of prepare() functionality
when adding/removing plugins?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message