cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: CB-9632 Fixed tests not to fail on T...
Date Wed, 09 Sep 2015 17:01:49 GMT
Github user purplecabbage commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/121#discussion_r39068742
  
    --- Diff: spec/unit/deployment.spec.js ---
    @@ -150,7 +151,7 @@ describe('Windows 10 deployment interacts with the file system as
expected.', fu
     describe('Windows 8.1 deployment interacts with the file system as expected.', function()
{
     
         function runMock(cmd, args, cwd) {
    -        expect(cmd).toBe('c:\\Program Files (x86)\\Microsoft SDKs\\Windows Phone\\v8.1\\Tools\\AppDeploy\\AppDeployCmd.exe');
    +        expect(cmd).toBe(path.join('c:', 'Program Files (x86)', 'Microsoft SDKs', 'Windows
Phone', 'v8.1', 'Tools', 'AppDeploy', 'AppDeployCmd.exe'));
    --- End diff --
    
    nit: This split is unnecessary. 
    path.join takes care of this already. You can pass in 'a\\b/c' and it will return the
right thing for the current system.
    Just do:
     `path.join('c:\\Program Files (x86)\\Microsoft SDKs\\Windows Phone\\v8.1\\Tools\\AppDeploy\\AppDeployCmd.exe')`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message