cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-9604 Fix error adding browser platfor...
Date Thu, 03 Sep 2015 06:56:31 GMT
Github user vladimir-kotikov commented on the pull request:

    https://github.com/apache/cordova-lib/pull/295#issuecomment-137353546
  
    Looks good. However there is another chance to access `this._config` before it will be
initialized: https://github.com/MSOpenTech/cordova-lib/blob/CB-9604/cordova-lib/src/platforms/PlatformApiPoly.js#L162.
    
    Probably it makes sense to eliminate "private" `this._config` and always use `platformInfo.projectConfig`
instead, which need to be a dynamic property with getter? Your thoughts? I can refactor this
by myself after.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message