cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dblotsky <...@git.apache.org>
Subject [GitHub] cordova-docs pull request: Adding linting, link verifier and slack...
Date Tue, 01 Sep 2015 00:30:34 GMT
Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/323#discussion_r38375651
  
    --- Diff: gulpfile.js ---
    @@ -247,6 +250,23 @@ gulp.task("link-bugs", function (done) {
         exec(bin("linkify-bugs.sh"), [path.join(SOURCE_DIR, "_posts")], done);
     });
     
    +gulp.task('lint', function() {
    +    return gulp.src(path.join(LINT_DIR, "**", "*.html"))
    +        .pipe(htmllint());
    +});
    +
    +gulp.task('checklinks', function(cb) {
    +  crawler.crawl('http://localhost:3000/')
    --- End diff --
    
    A server should be running for this task to succeed, but a server should not be started
every time this task runs. Let's instead encode this dependency by adding a statement like
`console.log("Make sure the server is running on " + SERVE_URL + "before running this task.")`
to the `'checklinks'` task.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message