Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0958D18C4A for ; Thu, 13 Aug 2015 23:30:25 +0000 (UTC) Received: (qmail 3471 invoked by uid 500); 13 Aug 2015 23:30:24 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 3429 invoked by uid 500); 13 Aug 2015 23:30:24 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 3417 invoked by uid 99); 13 Aug 2015 23:30:24 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Aug 2015 23:30:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id E214CC212E for ; Thu, 13 Aug 2015 23:30:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.15 X-Spam-Level: *** X-Spam-Status: No, score=3.15 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, HTML_MESSAGE=3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 5xOcOGRFBxI1 for ; Thu, 13 Aug 2015 23:30:10 +0000 (UTC) Received: from mail-ob0-f173.google.com (mail-ob0-f173.google.com [209.85.214.173]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTPS id 8F7CB20786 for ; Thu, 13 Aug 2015 23:30:09 +0000 (UTC) Received: by obbhe7 with SMTP id he7so49475799obb.0 for ; Thu, 13 Aug 2015 16:30:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=bfUveGw+uPA/bUwikoK02zxpekVgl3BSzOmnuGFDd2c=; b=V1/OJuKCAE/AUNqp7eQhBB1PtVeeCrkWcQ7nXjiqwKyazvQZ0muRPxGGcMO8K4wOpF O/Dar/IQfTu1QUVrppknAboDR5VAKkgRx5J6vy7uETZBcKeGJ/65Bq16BNqFE5oNRGQV Nt5Gm1n3gUZP2PjGRGn+QtZYzaEaFQO3vQ15TogTbTTqbXpwa/5TxY6RSANv5dWLs91y 3gGzffKLMTqrrClL8cQY+uR6D5D1WFPrPx6k89MgIuwx3LjcRz2hWUMOBZf8spLa0O0q Uhf7k41TKnhYh9il/gfH9zttVhJZB2NTtMlXgyHq1xvk5YWntb27S1AtMNQ/LVvdArr6 8Efw== X-Received: by 10.60.65.68 with SMTP id v4mr29280817oes.84.1439508608385; Thu, 13 Aug 2015 16:30:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.245.131 with HTTP; Thu, 13 Aug 2015 16:29:49 -0700 (PDT) In-Reply-To: References: From: Steven Gill Date: Thu, 13 Aug 2015 16:29:49 -0700 Message-ID: Subject: Re: questions about coho audit-license-headers and check-license To: "dev@cordova.apache.org" Content-Type: multipart/alternative; boundary=001a11c1cb684108f9051d39b756 --001a11c1cb684108f9051d39b756 Content-Type: text/plain; charset=UTF-8 Yeah I think that was the problem. It started happening once I switched machines. Not a big deal. On Thu, Aug 13, 2015 at 4:16 PM, Shazron wrote: > I think someone else on the team needs to key sign Steve's key (use GPG > Keychain). I just did for both his apache and gmail keys. > > On Fri, Aug 14, 2015 at 4:55 AM, Homer, Tony wrote: > > > Thanks for replying Steve - I see what you mean about dependencies, > hadn't > > thought about that. > > > > When I did `coho verify-archive` I got "gpg: WARNING: This key is not > > certified with a trusted signature!". > > I guess this is ok, but is there any way to address the warning? > > > > > > On 8/13/15, 2:47 PM, "Steven Gill" wrote: > > > > >Audit license headers is the important one. > > > > > >At the end of the day, we aren't shipping any of our dependencies. They > > >are > > >all downloaded by our users. We can contact module authors who don't > have > > >license listed to get them to list one. > > > > > >-Steve > > > > > >On Thu, Aug 13, 2015 at 5:40 AM, Homer, Tony > > wrote: > > > > > >> I'm trying to validate the tools release. > > >> I'm following the instructions[1], but I haven't used coho before and > am > > >> not sure about the results. > > >> > > >> `coho audit-license-headers -r js -r lib -r cli -r plugman` > > >> The doc warns that audit-license-headers has false positives, so I'm > > >> ignoring the following results: > > >> ./appveyor.yml > > >> ./tasks/vendor/commonjs-tests/* > > >> ./tasks/vendor/jasmine/* > > >> ./spec-cordova/* > > >> ./spec-plugman/* > > >> ./src/plugman/help.txt > > >> Are these are all false positives? > > >> If yes, I think the audit-license-headers results are ok. > > >> > > >> `coho check-license -r tools` > > >> I got a lot of results so I started adding what I think are false > > >> positives to the license filter: > > >> "ISC","Public Domain","WTFPL","ASF","Unlicense","Artistic-2.0" > > >> I also updated to nlf 1.3.2 in order to get nicer output and a fix for > > >>the > > >> single license under licenses bug [2]. > > >> I still get 88 results for packages with no license entry in > > >>package.json. > > >> (plus xmldom, which has a syntax error in the license entry but has an > > >> Apache-compatible license) > > >> > > >> Are "ISC","Public Domain","WTFPL","ASF","Unlicense","Artistic-2.0" all > > >> Apache-compatible? > > >> Are packages with no license entry ok - any additonal action required? > > >> Should I submit a PR to add the additional license strings to the > filter > > >> and update nlf? > > >> > > >> [1] > > >> > > >> > > > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-pro > > >>cess.md#test > > >> [2] https://github.com/iandotkelly/nlf/pull/22 > > >> > > >> > > >> --------------------------------------------------------------------- > > >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org > > >> For additional commands, e-mail: dev-help@cordova.apache.org > > >> > > >> > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org > > For additional commands, e-mail: dev-help@cordova.apache.org > > > > > --001a11c1cb684108f9051d39b756--