Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: nikhilkh <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-209-cordova-android@git.apache.org>
In-Reply-To: <git-pr-209-cordova-android@git.apache.org>
Subject: [GitHub] cordova-android pull request: CB-9557 Fixes apk install
 failure wh...
Content-Type: text/plain
Message-Id: <20150826155944.DB702E046A@git1-us-west.apache.org>
Date: Wed, 26 Aug 2015 15:59:44 +0000 (UTC)

Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/209#discussion_r37999874
  
    --- Diff: bin/templates/cordova/lib/device.js ---
    @@ -96,10 +96,15 @@ module.exports.install = function(target, buildResults) {
         }).then(function(resolvedTarget) {
             var apk_path = build.findBestApkForArchitecture(buildResults, resolvedTarget.arch);
             var launchName = appinfo.getActivityName();
    +        var pkgName = appinfo.getPackageName();
             console.log('Using apk: ' + apk_path);
    -        console.log('Installing app on device...');
    -        var cmd = 'adb -s ' + resolvedTarget.target + ' install -r "' + apk_path + '"';
    -        return exec(cmd, os.tmpdir())
    +        console.log('Uninstalling ' + pkgName + ' from device...');
    +        return exec('adb -s ' + resolvedTarget.target + ' uninstall ' + pkgName, os.tmpdir())
    --- End diff --
    
    Wouldn't uninstalling always cause a failure - especially on the first run?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org