cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TimBarham <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-9559 Adding a plugin with caret in ve...
Date Fri, 28 Aug 2015 04:03:51 GMT
GitHub user TimBarham opened a pull request:

    https://github.com/apache/cordova-lib/pull/291

    CB-9559 Adding a plugin with caret in version results in an error

    When Cordova used `npm 1.3.x` internally, we had to process "caret versions" since `npm
1.3.x` didn't understand them. As part of that, we'd turn the caret version into a fully defined
version range, which contained a space, and `npm 1.3.x` required that we wrap such a range
in quotes.
    
    This logic broke when we upgraded to `npm 2.10.x` - it no longer requires the quotes in
this scenario, and in fact fails if we include them. However, we also no longer need to do
this processing (since `npm 2.10.x` understands caret versions), so we can just remove that
code altogether.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-lib CB-9559

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/291.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #291
    
----
commit 7db936a9502c2e5de7288e68792e5eba90074a43
Author: Tim Barham <tim.barham@microsoft.com>
Date:   2015-08-28T03:39:19Z

    CB-9559 Adding a plugin with caret in version results in an error
    
    When Cordova used npm 1.3.x internally, we had to process "caret versions" since npm 1.3.x
didn't understand them. As part of that, we'd turn the caret version into a fully defined
version range, which contained a space, and npm 1.3.x required that we wrap such a range in
quotes.
    
    This logic broke when we upgraded to npm 2.10.x - it no longer requires the quotes in
this scenario, and in fact fails if we include them. However, we also no longer need to do
this processing (since npm 2.10.x understands caret versions), so we can just remove that
code altogether.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message