cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-9505 Correct plugin modules loading w...
Date Tue, 18 Aug 2015 11:34:11 GMT
GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-lib/pull/279

    CB-9505 Correct plugin modules loading within browserify flow

    This PR solves problem with a lot of plugins, which uses `js-module` tags with `merges
target=""`. Such modules are not loaded correctly, so, for example, plugin proxies on windows
platform are not available at runtime.
    
    Instead of injecting `modulemapper` methods and `require` calls into bundle, this PR assumes
that bundled plugins modules will be loaded by special 'browserify' version of `cordova/pluginloader`
(see https://github.com/MSOpenTech/cordova-js/blob/CB-9505/src/common/pluginloader_b.js)
    
    This fixes https://issues.apache.org/jira/browse/CB-9505
    
    This PR needs to be merged along with corresponding PR to cordova-js: https://github.com/apache/cordova-js/pull/126

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-lib CB-9505

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/279.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #279
    
----
commit e3a54a6c545aaa3e5af6d1158acd8f421bbf9131
Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
Date:   2015-08-18T10:43:05Z

    CB-9505 Correct plugin modules loading within browserify flow

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message