cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sarahgoldman <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: Manual dismissal method for iO...
Date Wed, 26 Aug 2015 19:49:35 GMT
GitHub user sarahgoldman opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/117

    Manual dismissal method for iOS

    I have added a new function called `dismiss` that allows one to dismiss any camera popover
views and view controllers on iOS. I encountered a need for this function when implementing
a timeout based logout on my app. If the user timed out while sitting there with the camera
open, I had no way to close the camera view controller and it would stay open on top of the
login page. When they finally took a photo it would exit the camera and they would be on the
login page. Now I can call `navigator.camera.dismiss()` before I go to the login view.
    
    `dismiss` does not take any callback handlers, instead it triggers the error callback
set with `getPicture` and sends a message stating the camera was dismissed. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sarahgoldman/cordova-plugin-camera master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #117
    
----
commit e906e2d30a4e67baace039c556af6f55b16a288b
Author: Sarah Goldman <sarahrgoldman@gmail.com>
Date:   2015-08-26T18:49:10Z

    added dismiss function for ios camera popover and view controller

commit 4f915e87544f586e4140739cb9e28591d40fd4ea
Author: Sarah Goldman <sarahrgoldman@gmail.com>
Date:   2015-08-26T19:19:00Z

    removed cordova.define statement, not sure how this got added since I didn't add it the
first time

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message