cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Bowser <bows...@gmail.com>
Subject Re: file transfer test failures on Android
Date Wed, 26 Aug 2015 21:43:20 GMT
Actually, I'm OK with either.  We should be replacing all control
characters though.

On Wed, Aug 26, 2015 at 2:40 PM Joe Bowser <bowserj@gmail.com> wrote:

> It should be an empty string.
>
> On Wed, Aug 26, 2015 at 2:13 PM Alexander Sorokin (Akvelon) <
> v-alsoro@microsoft.com> wrote:
>
>> Hi guys,
>>
>> I think there is a regression in file transfer plugin (two tests are
>> failing on Android):
>>
>> https://ci.apache.org/builders/cordova-android-win/builds/261/steps/getting-test-results/logs/stdio
>> This is caused by latest commit:
>>
>> https://github.com/apache/cordova-plugin-file-transfer/commit/ad6647120db12f0e67ee4a952a71ea494a39a475#diff-4480f457f31b87b365a8ed3f1b7e9c36R222
>>
>> The code is replacing all whitespace characters in headers with an empty
>> string. Should it be a space character?
>>
>> If so, here is my proposed fix for that:
>> https://github.com/apache/cordova-plugin-file-transfer/pull/99
>>
>> Thanks,
>> Alexander Sorokin
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message